feat: new module: avm/res/network/network-security-perimeter#4278
feat: new module: avm/res/network/network-security-perimeter#4278AlexanderSehr merged 8 commits intoAzure:mainfrom
avm/res/network/network-security-perimeter#4278Conversation
microsoft-github-policy-service
bot
added
Needs: Triage 🔍
avm-organizer
bot
added
the
Needs: Core Team 🧞
eriqua
added
Class: Resource Module 📦
|
Could somebody take a look at this PR pls? |
I'll jump in here @peterbud. |
avm/res/network/network-security-perimeter/tests/e2e/max/main.test.bicep
Show resolved
Hide resolved
|
@peterbud, @AlexanderSehr, it looks like some of the tests have failed, and the module didn't get published yet. https://github.com/Azure/bicep-registry-modules/actions/runs/13464660027 |
|
@matebarabas @AlexanderSehr The error message suggests that the feature is NOT enabled at the subscription. As I have mentioned at the top of the PR:
|
|
Ah at there very bottom. Next time, please add it to the top in the description. |
Sorry, I did not mean to hide it. |
Hey @jtracey93, |
…#4278) ## Description Adding new module `avm/res/network/network-security-perimeter` See Azure/Azure-Verified-Modules#1709 ## Pipeline Reference <!-- Insert your Pipeline Status Badge below --> | Pipeline | | -------- | | [](https://github.com/peterbud/bicep-registry-modules/actions/workflows/avm.res.network.network-security-perimeter.yml) | ## Type of Change <!-- Use the checkboxes [x] on the options that are relevant. --> - [ ] Update to CI Environment or utilities (Non-module affecting changes) - [ ] Azure Verified Module updates: - [ ] Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in `version.json`: - [ ] Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description. - [ ] The bug was found by the module author, and no one has opened an issue to report it yet. - [ ] Feature update backwards compatible feature updates, and I have bumped the MINOR version in `version.json`. - [ ] Breaking changes and I have bumped the MAJOR version in `version.json`. - [ ] Update to documentation ## Checklist - [x] I'm sure there are no other open Pull Requests for the same update/change - [x] I have run `Set-AVMModule` locally to generate the supporting module files. - [x] My corresponding pipelines / checks run clean and green without any errors or warnings Pls. note that network security perimeter should be specifically enabled in the subscription: https://learn.microsoft.com/en-us/azure/private-link/create-network-security-perimeter-portal#prerequisites <!-- Please keep up to date with the contribution guide at https://aka.ms/avm/contribute/bicep -->
](https://github.com/peterbud/bicep-registry-modules/actions/workflows/avm.res.network.network-security-perimeter.yml){kind=link}
|
@AlexanderSehr, @peterbud, given that this PR has been merged, but didn't get published due to the failing pipeline (which now also results in some side effects), I recommend moving ahead with the disclaimer approach: let's add one that clearly states that this module has a service currently in preview. |
4 participants
Description
Adding new module
avm/res/network/network-security-perimeterSee Azure/Azure-Verified-Modules#1709
Pipeline Reference
Type of Change
version.json:version.json.version.json.Checklist
Set-AVMModulelocally to generate the supporting module files.Pls. note that network security perimeter should be specifically enabled in the subscription:
https://learn.microsoft.com/en-us/azure/private-link/create-network-security-perimeter-portal#prerequisites