Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new module: avm/res/network/network-security-perimeter #4278

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

peterbud
Copy link
Contributor

@peterbud peterbud commented Jan 23, 2025

Description

Adding new module avm/res/network/network-security-perimeter

See Azure/Azure-Verified-Modules#1709

Pipeline Reference

Pipeline
avm.res.network.network-security-perimeter

Type of Change

  • Update to CI Environment or utilities (Non-module affecting changes)
  • Azure Verified Module updates:
    • Bugfix containing backwards-compatible bug fixes, and I have NOT bumped the MAJOR or MINOR version in version.json:
      • Someone has opened a bug report issue, and I have included "Closes #{bug_report_issue_number}" in the PR description.
      • The bug was found by the module author, and no one has opened an issue to report it yet.
    • Feature update backwards compatible feature updates, and I have bumped the MINOR version in version.json.
    • Breaking changes and I have bumped the MAJOR version in version.json.
    • Update to documentation

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • I have run Set-AVMModule locally to generate the supporting module files.
  • My corresponding pipelines / checks run clean and green without any errors or warnings

Pls. note that network security perimeter should be specifically enabled in the subscription:
https://learn.microsoft.com/en-us/azure/private-link/create-network-security-perimeter-portal#prerequisites

@peterbud peterbud requested review from a team as code owners January 23, 2025 17:55
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue labels Jan 23, 2025
@avm-team-linter avm-team-linter bot added the Needs: Core Team 🧞 This item needs the AVM Core Team to review it label Jan 23, 2025
@eriqua eriqua added Class: Resource Module 📦 This is a resource module and removed Needs: Triage 🔍 Maintainers need to triage still labels Jan 26, 2025
@peterbud
Copy link
Contributor Author

peterbud commented Feb 8, 2025

Could somebody take a look at this PR pls?

@AlexanderSehr
Copy link
Contributor

Could somebody take a look at this PR pls?

I'll jump in here @peterbud.

@@ -133,6 +133,7 @@
/avm/res/network/network-interface/ @Azure/avm-res-network-networkinterface-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/network/network-manager/ @Azure/avm-res-network-networkmanager-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/network/network-security-group/ @Azure/avm-res-network-networksecuritygroup-module-owners-bicep @Azure/avm-module-reviewers-bicep
/avm/res/network/network-security-perimeter/ @Azure/avm-res-network-networksecurityperimeter-module-owners-bicep @Azure/avm-module-reviewers-bicep
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently shows an error either because

  • The required teams (as per the contribution guide) don't exist - OR
  • The teams do exist, but are not added as children to the correct owner/contributor parent teams - OR
  • The teams do exist, and the request to add them to the correct parent teams is not yet approved

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just created the teams now.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @peterbud,
much appreciated, but that alone is not enough. As written in my initial comment, and as documented in the contribution guide here, the teams must also be

  • Added to the hierachy of the correct contributor & owner teams
  • Set 'adding' must be approved by the POs

This is required to ensure you, as the module owner, are able to later approve PRs for your own modules that were raised by a 2nd part.

Also on a sidenote: If possible, please only resolve comments if they're 'code suggestions' (the ones with the commit button) as all others should be re-reviewed by the person that created them. Otherwise a re-review like in this case is a bit tedious as I can't outright see what I originally commented on and if it was fixed. A comment 'addressed' below the review comment would be ideal, thanks :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the last one - I just checked the code an can see that actually none of the code suggestions below were addressed. If you applied them locally, you may have missed to push your changes. I'll go ahead and unresolve them

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have started working on this (therefore you see some resolved as I tracked them with the VSCode extension), but had to stop, and I'll push it later, when all feedback will be handled properly. Sorry for the confusion.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, all changes has been pushed, and resolved. pls have a look.

The contributor and owner teams are in place, they need to be approved by the parent owners.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Class: Resource Module 📦 This is a resource module Needs: Core Team 🧞 This item needs the AVM Core Team to review it Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants